Check entitlement while rekeying #2424
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # DuckDuckGo/UserText.swift # DuckDuckGo/en.lproj/Localizable.strings
6 tasks
# Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
graeme
reviewed
Feb 9, 2024
graeme
reviewed
Feb 14, 2024
graeme
reviewed
Feb 15, 2024
| } | ||
|
|
||
| #endif | ||
|
|
||
| extension PacketTunnelProvider.SubscriptionConfiguration { |
There was a problem hiding this comment.
I’m not sure this type makes sense as a subtype of the PacketTunnelProvider. It’s needed by the NetworkProtectionDeviceManager which is a dependency of the PacketTunnelProvider which creates a sort of circular dependency (not a serious one, but it is nonethless). Also the PacketTunnelProvider already quite bloated (we’ve got swiftlint warnings).
# Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
|
🚫 The Asana task linked in the PR description is not added to iOS App Board project.
|
github-actions
bot
added
the
bot: not in app board
|
Closing this in favor of #2461. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1206409081785855/f
Tech Design URL: https://app.asana.com/0/481882893211075/1206500582793508/f
CC:
Description:
This PRs add entitlement check while rekeying with NetP.
Steps to test this PR:
Refer to https://app.asana.com/0/0/1206398972819576/f for notes and test cases.
Copy Testing:
’rather than'Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
Internal references:
Software Engineering Expectations
Technical Design Template